Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Technical debt and clean up #397

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented Mar 13, 2023

Description

add repr to serializers, models and services classes, str to serializers,

Clean up test suite to provide consistency, use parameterization instead of loops, misc

use shorthands instead of verbose if-else statements in code base for readability

Issue ticket number and link

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Other Stuff

…serializers

misc cleanup for code base readability
@github-actions github-actions bot added database changes that require modification to the database schema server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included labels Mar 13, 2023
@dpgraham4401 dpgraham4401 merged commit bf96b96 into USEPA:main Mar 13, 2023
@dpgraham4401 dpgraham4401 deleted the technical_debt branch March 13, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database changes that require modification to the database schema server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant